-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rightmost tab corner #9575
Fix rightmost tab corner #9575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very cool with this as-is. If people don't like the gap, then maybe we could add a negative left margin on the new tab button to compensate?
I think it might be better to wait until WinUI finishes the new design, as it seems they're giving up on the bottom tabs corner. They're currently using a |
This could take some time. They're working on some new design components for the tab view, but we'll be sticking with the original design until such time as the new one becomes the default. 😄 |
Thanks again, and sorry for the delay. I'll fix your conflict. |
@msftbot merge this in 1 minute |
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Before and after: ![image](https://user-images.githubusercontent.com/78622729/111928492-710b9000-8abc-11eb-9760-0ecd3eb038fb.png) The bottom right corner appeared without a radius because of the custom padding. (cherry picked from commit 8f16fdd)
🎉 Handy links: |
🎉 Handy links: |
Before and after:
The bottom right corner appeared without a radius because of the custom padding.