-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable text search on combo boxes #9206
Conversation
This comment has been minimized.
This comment has been minimized.
Filed #9207 as a follow-up task. Settings model objects should not be |
Hello @DHowett! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 15 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I hate to block over just a trivial nit. So I won't block but I won't ✔️
🎉 Handy links: |
Is it possible to change the behaviour: "ComboBoxItem starting with those letters is shown" ? I want to type in only a part of the displayed value like the ending letters. |
@JeffJefferson I don't believe that's possible with a stock ComboBox. We'd need to entirely roll a forked version to support fuzzy matching. Maybe a good request for https://github.com/microsoft/microsoft-ui-xaml? Though, I'm not sure that fuzzy matching like that is common on most combobox UX's in any UI framework. Like, on the web, I'm pretty sure the matching is exclusive to the start of the string. (happy to be proven wrong) |
ComboBox
has a text search function that allows users to type letters, and theComboBoxItem
starting with those letters is shown. In order to enable this functionality, the underlying items must beIStringable
. This exposes aToString()
function and fixes all of our issues.This PR adds the
IStringable
interface toColorScheme
,Profile
, andEnumEntry
.References
#6800 - Settings UI Epic
#8768 - Keyboard Navigation
microsoft/microsoft-ui-xaml#4182 - discussion with WinUI about how to overcome this issue
Validation Steps Performed
Tested...
Also tested radio buttons, but those still don't work, unfortunately. Looks like they don't have the same underlying mechanism.