Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GH Action Super-Linter and README #7951

Merged
merged 4 commits into from
Oct 19, 2020
Merged

Update GH Action Super-Linter and README #7951

merged 4 commits into from
Oct 19, 2020

Conversation

WSLUser
Copy link
Contributor

@WSLUser WSLUser commented Oct 16, 2020

Summary of the Pull Request

Updates the GH Action and makes a small update to the README to test changes.

References

PR Checklist

  • Closes Scoop install  #7934
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed N/A
  • Documentation updated. If checked, please file a pull request on [our docs repo] (https://github.com/MicrosoftDocs/terminal) and link it here: N/A this is the README doc.
  • Schema updated. N/A
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: Scoop install  #7934

Detailed Description of the Pull Request / Additional comments

A missing install step for Windows Terminal using Scoop has been added. The versioning of Super-Linter was also switched to v3 to allow auto-updates within the v3 series. This can be version-pinned again if a breaking change comes later. The current updates fix some bugs and bump the linters utilized.

Validation Steps Performed

Validation will be shown in the build steps.

@WSLUser
Bump version of Super-Linter
9110343 
Contains bug fixes and updated linters.
@WSLUser
Update README.md
7cbd749
@WSLUser
Switch to v3 versioning
404502d 
Allows automatic updates within the version 3 series
@WSLUser
Add fetch depth from updated README
75283a4 
Add fetch depth to get proper list of changed files within 'super-linter'.
@ghost ghost added Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Meta The product is the management of the products. labels Oct 16, 2020
@WSLUser WSLUser changed the title Update GH Action Super-Linter and update README Update GH Action Super-Linter and README Oct 16, 2020
@WSLUser
Copy link
Contributor Author

WSLUser commented Oct 16, 2020

Also can you add the Hacktoberfest labels for this PR and my previous one that added the Super-Linter? I signed up for it. Hoping to get a shirt!

zadjii-msft
zadjii-msft approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure.

DHowett
DHowett approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@DHowett DHowett merged commit c1d2777 into microsoft:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Meta The product is the management of the products.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scoop install
3 participants
@WSLUser @DHowett @zadjii-msft