When win32 is resizing the viewport, make sure Right > Left #7768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes when we were sliding the viewport to fit inside the buffer, we would end up with left > right. That would cause us to crash down the line when rendering. Fixes #7744. (cherry picked from commit 3687fa1cac78d88d32accd53f25f05466dcea1f9)
ghost
added
Area-Output
DHowett
changed the title
miniksa
approved these changes
Sep 28, 2020
ghost
requested review from
zadjii-msft,
carlos-zamora,
leonMSFT and
PankajBhojwani
| // from having a negative width later. | ||
| srNewViewport.Right -= offRightDelta; | ||
| srNewViewport.Left = std::max<SHORT>(0, srNewViewport.Left - offRightDelta); | ||
| } | ||
| srNewViewport.Bottom = std::min(srNewViewport.Bottom, gsl::narrow<SHORT>(coordScreenBufferSize.Y - 1)); |
There was a problem hiding this comment.
We don't need to do the same thing down here?
There was a problem hiding this comment.
Not pressingly. No hits on crashes because of negative height. The reason this is crashing is til::manage_vector is being given a huge size (negative size w/ 2's complement representation) when allocating preallocated storage for the buffer width.
carlos-zamora
approved these changes
Sep 28, 2020
DHowett
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when we were sliding the viewport to fit inside the buffer, we
would end up with left > right.
That would cause us to crash down the line when rendering.
Fixes MSFT:28387423.
Fixes #7744.
Validation
Manual run through 100% repro test case.