Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for creating a new DLL #7661

Merged
merged 8 commits into from
Sep 22, 2020
Merged

Add docs for creating a new DLL #7661

merged 8 commits into from
Sep 22, 2020

Conversation

leonMSFT
Copy link
Contributor

@leonMSFT leonMSFT commented Sep 18, 2020 •
edited
Loading

This PR adds a docs page for the gotchas and things to do when creating a new WinRT dll project.

DHowett
DHowett approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you!

leonMSFT and others added 2 commits September 21, 2020 15:20
miniksa
miniksa approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with it as is, but gave you two places to expand if you want to before you merge it.

@leonMSFT
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@leonMSFT leonMSFT merged commit 9539ec3 into master Sep 22, 2020
@leonMSFT leonMSFT deleted the dev/lelian/buildtroubleshootingdocs branch September 22, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniksa miniksa miniksa approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leonMSFT @DHowett @miniksa