Give Tab ownership of its SwitchToTab command #7659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
reviewed
Sep 17, 2020
| namespace TerminalApp | ||
| { | ||
| [default_interface] runtimeclass Tab : Windows.UI.Xaml.Data.INotifyPropertyChanged | ||
| { | ||
| String Title { get; }; | ||
| Windows.UI.Xaml.Controls.IconSource IconSource { get; }; | ||
| Command SwitchToTabCommand { get; }; | ||
| UInt32 TabViewIndex { get; }; |
There was a problem hiding this comment.
feel free to just call this "Index"
DHowett
approved these changes
Sep 17, 2020
ghost
requested review from
zadjii-msft,
miniksa,
carlos-zamora and
PankajBhojwani
carlos-zamora
approved these changes
Sep 18, 2020
DHowett
pushed a commit
that referenced
this pull request
Oct 27, 2020
Currently, `CommandPalette` creates and maintains the `SwitchToTab` commands used for the ATS. When `Command` goes into the TerminalSettingsModel, the palette won't be able to access `Command`'s implementation type, making it difficult for `CommandPalette` to tell `Command` to listen to `Tab` for changes. This PR changes the relationship up so `Tab` now manages its `SwitchToTab` command, and `CommandPalette` just plops the command from `Tab` into its list. (cherry picked from commit 468c8c6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
CommandPalettecreates and maintains theSwitchToTabcommands used for the ATS. When
Commandgoes into theTerminalSettingsModel, the palette won't be able to access
Command'simplementation type, making it difficult for
CommandPaletteto tellCommandto listen toTabfor changes.This PR changes the relationship up so
Tabnow manages itsSwitchToTabcommand, andCommandPalettejust plops the command fromTabinto its list.