Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the "user docs" with references to the real docs #7649

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Sep 16, 2020

I have filed MicrosoftDocs/terminal#138 with some of the snippets removed from these docs, like the tips/tricks from settings.

PR Checklist

  • Closes a bug
  • CLA signed
  • Tests added/passed
  • Documentation updated
  • Schema updated
  • I work here

@WSLUser
Copy link
Contributor

WSLUser commented Sep 17, 2020

Don't forget about MicrosoftDocs/terminal#98. I think the doc belongs there and should help reduce the amount of issues we get asking for setting up different custom profiles.

@DHowett
Copy link
Member Author

DHowett commented Sep 17, 2020

That’s why I haven’t yet removed ThirdPartyProfiles! :)

@cinnamon-msft
Copy link
Contributor

Thanks for doing this!!

Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear you had a PR before that tried to do something similar, but I couldn't find it.

I also swear that there was an issue that that PR closed, but, again, I couldn't find it.

@DHowett
Copy link
Member Author

DHowett commented Sep 17, 2020

There was a PR (keyword: “upstate”) and there was not an issue linked from it!

@DHowett DHowett merged commit 5d823f5 into master Sep 17, 2020
@DHowett DHowett deleted the dev/duhowett/upstate branch September 17, 2020 16:38
@DHowett DHowett restored the dev/duhowett/upstate branch September 17, 2020 16:38
@DHowett DHowett deleted the dev/duhowett/upstate branch September 17, 2020 16:38
@mattwojo
Copy link
Member

Added 3rd party profiles to docs.ms in case you want to remove and close this. MicrosoftDocs/terminal#366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants