Introduce KeyMapping and Move TerminalSettings construction #7537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
leonMSFT
reviewed
Sep 8, 2020
agniutkarsh
approved these changes
Sep 11, 2020
DHowett
requested changes
Sep 11, 2020
| @@ -1030,8 +1030,7 @@ namespace winrt::TerminalApp::implementation | |||
| const auto& profileGuid = focusedTab->GetFocusedProfile(); | |||
| if (profileGuid.has_value()) | |||
| { | |||
| const auto settingsImpl{ winrt::get_self<implementation::CascadiaSettings>(_settings) }; | |||
| const auto settings = settingsImpl->BuildSettings(profileGuid.value()); | |||
| const auto settings{ winrt::make<TerminalSettings>(_settings, profileGuid.value(), *_bindings) }; | |||
There was a problem hiding this comment.
how is this different from BuildSettings?
There was a problem hiding this comment.
| Function | Params |
|---|---|
Constructor |
CascadiaSettings, guid, IKeyBindings |
BuildSettings |
CascadiaSettings, NewTerminalArgs, IKeyBindings |
Before, they were both BuildSettings. But the second BuildSettings needs to return a tuple so we can't just make that another constructor :(
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
…osoft/Terminal into dev/cazamor/set/key-mapping
DHowett
reviewed
Sep 14, 2020
DHowett
approved these changes
Sep 14, 2020
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyMappingwas introduced to break upAppKeyBindings.KeyMappingrecords the keybindings from the JSON and lets you query them.
AppKeyBindingsnow just holds aShortcutActionDispatcherto runactions, and a
KeyMappingto record/query your existing keybindings.This refactor allows
KeyMappingto be moved to theTerminalSettingsModel, and
ShortcutActionDispatcherandAppKeyBindingswill stay in TerminalApp.AppKeyBindingshad to be passed down to a terminal viaTerminalSettings. Since each settings object had its ownresponsibility to update/create a
TerminalSettingsobject, I moved allof that logic to
TerminalSettings. This helps with theTerminalSettingsModel refactor, and makes the construction of
TerminalSettingsa bit cleaner and more centralized.References
#885 - this is all in preparation for the TerminalSettingsModel
Validation Steps Performed