Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schema for setColorScheme #7433

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Fix schema for setColorScheme #7433

merged 1 commit into from
Aug 27, 2020

Conversation

cinnamon-msft
Copy link
Contributor

@cinnamon-msft cinnamon-msft commented Aug 27, 2020 •
edited by DHowett
Loading

setColorScheme should require colorScheme rather than name

zadjii-msft
zadjii-msft approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my b

@DHowett DHowett merged commit 9283781 into master Aug 27, 2020
@DHowett DHowett deleted the cinnamon-msft-patch-1 branch August 27, 2020 17:11
DHowett pushed a commit that referenced this pull request Aug 27, 2020
@cinnamon-msft @DHowett
Fix schema for setColorScheme (#7433)
1a7d934 
`setColorScheme` should require `colorScheme` rather than `name`

(cherry picked from commit 9283781)
@DHowett
Copy link
Member

DHowett commented Aug 27, 2020

Picked to release-1.3 (even though nobody is using that schema link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cinnamon-msft @DHowett @carlos-zamora @zadjii-msft