Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ProcessTestResults job to use conditions specified in parent #7347

Merged
2 commits merged into from
Aug 19, 2020

Conversation

miniksa
Copy link
Member

@miniksa miniksa commented Aug 19, 2020

Activating a template doesn't actually process conditions. Only jobs, stages, and tasks can process a condition. So specify the full condition in the parent template call as a parameter and ask the child job (who can actually evaluate the condition) to use that parameter to determine if it should run.

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this is horrifying

@miniksa miniksa marked this pull request as ready for review August 19, 2020 17:11
@miniksa miniksa added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Conhost For issues in the Console codebase Product-Conpty For console issues specifically related to conpty Product-Terminal The new Windows Terminal. labels Aug 19, 2020
@zadjii-msft zadjii-msft added Product-Meta The product is the management of the products. and removed Product-Conpty For console issues specifically related to conpty Product-Terminal The new Windows Terminal. Product-Conhost For issues in the Console codebase labels Aug 19, 2020
@miniksa miniksa added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 19, 2020
@ghost
Copy link

ghost commented Aug 19, 2020

Hello @miniksa!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 24 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@miniksa
Copy link
Member Author

miniksa commented Aug 19, 2020

@msftbot wait like 1 minute

@ghost
Copy link

ghost commented Aug 19, 2020

Hello @miniksa!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Wed, 19 Aug 2020 18:06:34 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 5a0deca into master Aug 19, 2020
@ghost ghost deleted the dev/miniksa/upsidedown_evaluation_totally_makes_sense branch August 19, 2020 19:31
MichelleTanPY pushed a commit to MichelleTanPY/terminal that referenced this pull request Aug 20, 2020
…rosoft#7347)

Activating a template doesn't actually process conditions. Only jobs, stages, and tasks can process a condition. So specify the full condition in the parent template call as a parameter and ask the child job (who can actually evaluate the condition) to use that parameter to determine if it should run.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Meta The product is the management of the products.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants