Make sure we check to profile shortcuts with an index >9 #7344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Settings
zadjii-msft
approved these changes
Aug 19, 2020
DHowett
requested changes
Aug 20, 2020
Comment on lines
465
to
466
| // add the keyboard shortcuts based on the number of profiles defined | ||
| if (profileIndex < profileCount) |
There was a problem hiding this comment.
Suggested change
| // add the keyboard shortcuts based on the number of profiles defined | |
| if (profileIndex < profileCount) |
Since we're in a loop from 0 to profileCount, we're just guaranteed that this is true. We can simplify this code by removing the check. If you want, you can keep the {} for this block to keep it logically separated from the rest of the code, however.
There was a problem hiding this comment.
Ok sure, make sense. I've removed that condition in the loop and updated the indentation.
ghost
added
Needs-Author-Feedback
MichelleTanPY
force-pushed
the
update-profile-shortcut
branch
from
d42a783
to
21de7aa
Compare
1. Remove unnessary conditional check in loop. 2. Update indentation and code comments.
DHowett
approved these changes
Aug 20, 2020
|
This is lovely. Thanks! |
DHowett
changed the title
DHowett
pushed a commit
that referenced
this pull request
Aug 24, 2020
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Update profile shortcut based on profiles defined.
PR Checklist
Validation Steps Performed
Added more profiles and able to create new tab.
Note: This binding doesn't work tho
{ "command": { "action": "newTab", "index": 10 }, "keys": "ctrl+shift+0" }