Expose selection background and alpha through the WPF control #7339
Conversation
Co-authored-by: Mike Griese <[email protected]>
Co-authored-by: Mike Griese <[email protected]>
| public uint DefaultSelectionBackground; | ||
|
|
||
| /// <summary> | ||
| /// The opacity alpha for the selection color of the terminal, must be between 1.0 and 0.0. | ||
| /// </summary> | ||
| public float SelectionBackgroundAlpha; |
There was a problem hiding this comment.
this isn't going to be an issue for VS, but... in the future, there will be more consumers for these things. How should we ensure that new fields don't break them?
There was a problem hiding this comment.
This is a good question to ask. I'm not sure what the best plan for this might be, and I don't want to maintain different versions of this API for every update we push.
What is the design patter the rest of the Windows Console follows for API breaking changes?
There was a problem hiding this comment.
Our solution is don't touch the Console API. I believe we've started using a few unused bits in other flags in existing APIs, but we don't touch the console API.
DHowett
changed the title
DHowett
changed the title
Adds the ability to set the selection background opacity when setting the selection background. This also exposes the selection background and alpha through the terminal WPF container. (cherry picked from commit 20b7fe4)
|
@DHowett while we get out own WPF Signed package pipeline set up, could we get a signed package of the terminal WPF control from the main branch that includes this change? |
|
Or if you can point me to the pipeline that builds and signs this package I can reference that :) |
|
I've got good news on that front 😄 We're about to move 1.2 to stable, and I published an update to the wpf control in our TerminalDependencies feed with this change cherry-picked into it. Formal release announcement e-mail is coming later, but: 1.2 brings a lot of new VT support and some better color fidelity when coupled with a 1.2+ openconsole |
Summary of the Pull Request
Adds the ability to set the selection background opacity when setting the selection background. This also exposes the selection background and alpha through the terminal WPF container.
Validation Steps Performed
Patched VS and ran the terminal tool window with multiple selection background colors and alphas.