-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken localtests #7333
Fix broken localtests #7333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting these fixed up so quickly.
Hello @miniksa! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 23 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
@msftbot wait like 5 minutes before merging |
Hello @miniksa! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
…caltests # Conflicts: # src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp # src/cascadia/LocalTests_TerminalApp/TabTests.cpp
We've had a number of ignored test failures for a while now. They're all
in the localtests, which we don't run in CI, so we've been ignoring
them. Plus, I thought that they were due to some test failure in the way
they were authored, so we just let them be.
Turns out, most of them worked just fine. Many were probably just
temporary test failures that got fixed with subsequent PRs.
The only one that's truly tricky here is the
TryCreateTab
testremoval. From what I can tell, that test would create a
Tab
, but notattach the
TabViewItem
to the XAML tree at all. But then after thetest was cleaned up, the tab's
_UpdateTitle
coroutine would resume,and it would try to get the
Tab
from theweak_this
. That weakpointer would now be pointing at random memory, and the
get_strong
would crash. However, the test runner would already be in the middle
of some other test, so it would cause a failure in a random test, not
the
TryCreateTab
test.So I'm just getting rid of it entirely. The
TryInitializePage
test ismore comprehensive and does work, so we'll just use that (and
derivatives) to test the creation of tabs.