Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken localtests #7333

Merged
merged 5 commits into from
Aug 18, 2020
Merged

Fix broken localtests #7333

merged 5 commits into from
Aug 18, 2020

Conversation

zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Aug 18, 2020

We've had a number of ignored test failures for a while now. They're all
in the localtests, which we don't run in CI, so we've been ignoring
them. Plus, I thought that they were due to some test failure in the way
they were authored, so we just let them be.

Turns out, most of them worked just fine. Many were probably just
temporary test failures that got fixed with subsequent PRs.

The only one that's truly tricky here is the TryCreateTab test
removal. From what I can tell, that test would create a Tab, but not
attach the TabViewItem to the XAML tree at all. But then after the
test was cleaned up, the tab's _UpdateTitle coroutine would resume,
and it would try to get the Tab from the weak_this. That weak
pointer would now be pointing at random memory, and the get_strong
would crash. However, the test runner would already be in the middle
of some other test, so it would cause a failure in a random test, not
the TryCreateTab test.

So I'm just getting rid of it entirely. The TryInitializePage test is
more comprehensive and does work, so we'll just use that (and
derivatives) to test the creation of tabs.

@ghost ghost added Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Aug 18, 2020
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting these fixed up so quickly.

@miniksa miniksa added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 18, 2020
@ghost
Copy link

ghost commented Aug 18, 2020

Hello @miniksa!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 23 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@miniksa
Copy link
Member

miniksa commented Aug 18, 2020

@msftbot wait like 5 minutes before merging

@ghost
Copy link

ghost commented Aug 18, 2020

Hello @miniksa!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 18 Aug 2020 18:02:26 GMT, which is in 5 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

…caltests

# Conflicts:
#	src/cascadia/LocalTests_TerminalApp/SettingsTests.cpp
#	src/cascadia/LocalTests_TerminalApp/TabTests.cpp
@miniksa miniksa merged commit b8b0dd7 into master Aug 18, 2020
@miniksa miniksa deleted the dev/migrie/b/fix-localtests branch August 18, 2020 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
3 participants