Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for commands iterable on color schemes #7329

Merged
6 commits merged into from
Aug 19, 2020

Conversation

zadjii-msft
Copy link
Member

Summary of the Pull Request

cmdpal-set-color-scheme

Allows for creating commands that iterate over the user's color schemes. Also adds a top-level nested command to defaults.json that allows the user to select a color scheme (pictured above). I'm not sure there are really any other use cases that make sense, but it really makes sense for this one.

References

PR Checklist

  • Closes wait what? I could have swore there was an issue for this one...
  • I work here
  • Tests added/passed
  • Requires documentation to be updated - okay maybe now I'll write some docs

Detailed Description of the Pull Request / Additional comments

Most of the hard work for this was already done in #6856. This is just another thing to iterate over.

Validation Steps Performed

  • Played with this default command. It works great.
  • Added tests.

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Aug 18, 2020
{
"name": "iterable command ${scheme.name}",
"iterateOn": "schemes",
"command": { "action": "splitPane", "profile": "${scheme.name}" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL, well, i mean.. it's effective for sure

@carlos-zamora carlos-zamora removed their assignment Aug 18, 2020
@zadjii-msft zadjii-msft requested a review from DHowett August 18, 2020 22:04
src/cascadia/TerminalApp/Command.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/TerminalPage.cpp Outdated Show resolved Hide resolved
@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 18, 2020
@DHowett DHowett assigned zadjii-msft and unassigned DHowett Aug 18, 2020
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 19, 2020
@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 19, 2020
@ghost
Copy link

ghost commented Aug 19, 2020

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit eecdd53 into master Aug 19, 2020
@ghost ghost deleted the dev/migrie/f/iterate-on-schemes branch August 19, 2020 17:33
@zadjii-msft zadjii-msft mentioned this pull request Aug 19, 2020
52 tasks
MichelleTanPY pushed a commit to MichelleTanPY/terminal that referenced this pull request Aug 20, 2020
## Summary of the Pull Request

![cmdpal-set-color-scheme](https://user-images.githubusercontent.com/18356694/90517094-8eddd480-e12a-11ea-8be4-8b6782d8d88c.gif)

Allows for creating commands that iterate over the user's color schemes. Also adds a top-level nested command to `defaults.json` that allows the user to select a color scheme (pictured above). I'm not sure there are really any other use cases that make sense, but it _really_ makes sense for this one.

## References
* microsoft#5400 - cmdpal megathread
* made possible by microsoft#6856, _and support from viewers like you._
* All this is being done in pursuit of microsoft#6689 

## PR Checklist
* [x] Closes wait what? I could have swore there was an issue for this one...
* [x] I work here
* [x] Tests added/passed
* [ ] Requires documentation to be updated - okay maybe now I'll write some docs

## Detailed Description of the Pull Request / Additional comments

Most of the hard work for this was already done in microsoft#6856. This is just another thing to iterate over.

## Validation Steps Performed
* Played with this default command. It works great.
* Added tests.
@ghost
Copy link

ghost commented Aug 26, 2020

🎉Windows Terminal Preview v1.3.2382.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants