-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for commands iterable on color schemes #7329
Conversation
{ | ||
"name": "iterable command ${scheme.name}", | ||
"iterateOn": "schemes", | ||
"command": { "action": "splitPane", "profile": "${scheme.name}" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL, well, i mean.. it's effective for sure
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
## Summary of the Pull Request ![cmdpal-set-color-scheme](https://user-images.githubusercontent.com/18356694/90517094-8eddd480-e12a-11ea-8be4-8b6782d8d88c.gif) Allows for creating commands that iterate over the user's color schemes. Also adds a top-level nested command to `defaults.json` that allows the user to select a color scheme (pictured above). I'm not sure there are really any other use cases that make sense, but it _really_ makes sense for this one. ## References * microsoft#5400 - cmdpal megathread * made possible by microsoft#6856, _and support from viewers like you._ * All this is being done in pursuit of microsoft#6689 ## PR Checklist * [x] Closes wait what? I could have swore there was an issue for this one... * [x] I work here * [x] Tests added/passed * [ ] Requires documentation to be updated - okay maybe now I'll write some docs ## Detailed Description of the Pull Request / Additional comments Most of the hard work for this was already done in microsoft#6856. This is just another thing to iterate over. ## Validation Steps Performed * Played with this default command. It works great. * Added tests.
🎉 Handy links: |
Summary of the Pull Request
Allows for creating commands that iterate over the user's color schemes. Also adds a top-level nested command to
defaults.json
that allows the user to select a color scheme (pictured above). I'm not sure there are really any other use cases that make sense, but it really makes sense for this one.References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Most of the hard work for this was already done in #6856. This is just another thing to iterate over.
Validation Steps Performed