Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add menu (also known as "app") as a bindable key #7328

Merged
1 commit merged into from
Aug 18, 2020
Merged

Add menu (also known as "app") as a bindable key #7328

1 commit merged into from
Aug 18, 2020

Conversation

MichelleTanPY
Copy link
Contributor

@MichelleTanPY MichelleTanPY commented Aug 18, 2020 •
edited by DHowett
Loading

  • Add MENU key with "menu" "app" as key bindings.
  • Updated profiles.schema.json and documentation.

Validation Steps Performed

Ran tests locally.
Tested out the new key binding.
{ "command": "openNewTabDropdown", "keys": "app" }

Closes #7144

@MichelleTanPY
Add MENU key for key binding.
4cdb532 
- Add MENU key with "menu" "app" as key bindings.
- Updated profiles.schema.json and documentation.
@ghost ghost added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Aug 18, 2020
@DHowett
Copy link
Member

DHowett commented Aug 18, 2020

Thanks for doing this!

@DHowett DHowett changed the title Add MENU key for key binding. Add menu (also known as "app") as a bindable key Aug 18, 2020
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 18, 2020
@ghost
Copy link

ghost commented Aug 18, 2020

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 1 hour 9 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett
Copy link
Member

DHowett commented Aug 18, 2020

@msftbot merge this in 5 minutes

@ghost
Copy link

ghost commented Aug 18, 2020

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 18 Aug 2020 17:21:25 GMT, which is in 5 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 93d2669 into microsoft:master Aug 18, 2020
@cinnamon-msft cinnamon-msft mentioned this pull request Aug 20, 2020
Closed
14 tasks
DHowett pushed a commit that referenced this pull request Aug 24, 2020
@MichelleTanPY @DHowett
Add menu (also known as "app") as a bindable key (#7328)
bc62dbb 
- Add MENU key with "menu" "app" as key bindings.
- Updated profiles.schema.json and documentation.

## Validation Steps Performed
Ran tests locally.
Tested out the new key binding.
```{ "command": "openNewTabDropdown", "keys": "app" }```

Closes #7144

(cherry picked from commit 93d2669)
@ghost
Copy link

ghost commented Aug 26, 2020

🎉Windows Terminal v1.2.2381.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Aug 26, 2020
Closed
@ghost
Copy link

ghost commented Aug 26, 2020

🎉Windows Terminal Preview v1.3.2382.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to bind "applications" key
3 participants
@MichelleTanPY @DHowett @zadjii-msft