Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable parallel build (again) and keep TerminalApp PCHs #7322

Merged
1 commit merged into from
Aug 18, 2020

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Aug 17, 2020

The build now builds every project multiple times, so I figure, why not
try to fix it.

The build now builds every project multiple times, so I figure, why not
try to fix it.
@DHowett DHowett marked this pull request as ready for review August 17, 2020 23:19
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. It is what it is.

@miniksa miniksa added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 17, 2020
@ghost
Copy link

ghost commented Aug 17, 2020

Hello @miniksa!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 20 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@miniksa
Copy link
Member

miniksa commented Aug 18, 2020

@msftbot wait 1 minute

@ghost
Copy link

ghost commented Aug 18, 2020

Hello @miniksa!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 18 Aug 2020 00:01:29 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit c4a9752 into master Aug 18, 2020
@ghost ghost deleted the dev/duhowett/i_mean_it_could_be_worse branch August 18, 2020 00:01
MichelleTanPY pushed a commit to MichelleTanPY/terminal that referenced this pull request Aug 18, 2020
)

The build now builds every project multiple times, so I figure, why not
try to fix it.
DHowett added a commit that referenced this pull request Aug 20, 2020
The build now builds every project multiple times, so I figure, why not
try to fix it.

(cherry picked from commit c4a9752)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants