Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scoop (unofficial) installation method #7303

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Add Scoop (unofficial) installation method #7303

merged 2 commits into from
Aug 18, 2020

Conversation

rashil2000
Copy link
Contributor

Summary of the Pull Request

This adds an (unofficial) installation method for Scoop package manager users. Many developers using Windows (me included) use and love Scoop, so this would be a nifty addition to the Readme.

PR Checklist

  • Documentation updated.

Detailed Description of the Pull Request

Made changes to README.md file.

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose I only have one qualm with this PR. Is there an official place to report issues with the Scoop install somewhere external to this repo? For example, the chocolatey install has a link to the chocolatey page for WT, so users who experience issues with the choco install can report them there.

Since we're not maintaining the scoop install or the scoop package, I'd rather not get issues here about people trying to install WT via scoop.

@zadjii-msft zadjii-msft added Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Terminal The new Windows Terminal. labels Aug 17, 2020
@rashil2000
Copy link
Contributor Author

rashil2000 commented Aug 17, 2020

The (awesome) thing about the installation process of Scoop is that the problem almost never arises (if it arises) due to Scoop itself. Anything and everything is maintained in a manifest, see this https://github.com/lukesampson/scoop-extras/blob/master/bucket/windows-terminal.json. It's just merely using the release archives of microsoft/terminal repository. If at all there's a problem, an issue can be raised in the repository where this manifest is maintained, and that is lukesampson/scoop-extras.

I can add an extra line here mentioning that the installation-specific issues can be reported in the aforementioned repository, if required.

@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 17, 2020
@zadjii-msft
Copy link
Member

I can add an extra line here mentioning that the installation-specific issues can be reported in the aforementioned repository, if required.

That would be preferred, thanks!

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 17, 2020
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 17, 2020
@github-actions
Copy link

New misspellings found, please review:

  • lukesampson
To accept these changes, run the following commands
perl -e '
my @expect_files=qw('".github/actions/spell-check/expect/af1ff90dc512c83c902762b02f284c1c61603b4a.txt
.github/actions/spell-check/expect/alphabet.txt
.github/actions/spell-check/expect/expect.txt
.github/actions/spell-check/expect/web.txt"');
@ARGV=@expect_files;
my @stale=qw('"Autogenerated Inplace notypeopt "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^($re)(?:$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect/37818d86d0ee831730eea50a862c3a16775d45e8.txt";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"autogenerated inplace lukesampson "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
git add .github/actions/spell-check/expect || echo '... you want to ensure .github/actions/spell-check/expect/37818d86d0ee831730eea50a862c3a16775d45e8.txt is added to your repository...'
✏️ Contributor please read this

By default the command suggestion will generate a file named based on your commit. That's generally ok as long as you add the file to your commit. Someone can reorganize it later.

⚠️ The command is written for posix shells. You can copy the contents of each perl command excluding the outer ' marks and dropping any '"/"' quotation mark pairs into a file and then run perl file.pl from the root of the repository to run the code. Alternatively, you can manually insert the items...

If the listed items are:

  • ... misspelled, then please correct them instead of using the command.
  • ... names, please add them to .github/actions/spell-check/dictionary/names.txt.
  • ... APIs, you can add them to a file in .github/actions/spell-check/dictionary/.
  • ... just things you're using, please add them to an appropriate file in .github/actions/spell-check/expect/.
  • ... tokens you only need in one place and shouldn't generally be used, you can add an item in an appropriate file in .github/actions/spell-check/patterns/.

See the README.md in each directory for more information.

🔬 You can test your commits without appending to a PR by creating a new branch with that extra change and pushing it to your fork. The :check-spelling action will run in response to your push -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. 😉

⚠️ Reviewers

At present, the action that triggered this message will not show its ❌ in this PR unless the branch is within this repository.
Thus, you should make sure that this comment has been addressed before encouraging the merge bot to merge this PR.

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes!

@miniksa miniksa merged commit 6eea6a3 into microsoft:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants