Add support for Commandline Mode to the CmdPal #7293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommand-Palette-v2 # Conflicts: # src/cascadia/TerminalApp/TerminalPage.h
Don't die when we encounter an unexpected key Reload successfully
…adow on the menuflyout???
…thing that uses MUX
…ommand-Palette-v2 # Conflicts: # src/cascadia/TerminalApp/GlobalAppSettings.cpp # src/cascadia/TerminalApp/GlobalAppSettings.h
# Conflicts: # src/cascadia/TerminalApp/ActionAndArgs.cpp # src/cascadia/TerminalApp/AppKeyBindingsSerialization.cpp
|
The.. people who write the typescript package that integrates C++ with VS Code might .. be able to help us with .. commandline parsing? 🤷 |
carlos-zamora
approved these changes
Aug 19, 2020
…-commandline-mode # Conflicts: # src/cascadia/TerminalApp/CommandPalette.h
…-commandline-mode
leonMSFT
suggested changes
Aug 21, 2020
ghost
added
the
Needs-Author-Feedback
ghost
removed
the
Needs-Author-Feedback
leonMSFT
approved these changes
Aug 24, 2020
|
This PR is currently blocked on the CI issue fixed over in #7383 @msftbot merge this in 5 minutes |
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
🎉 Handy links: |
ghost
mentioned this pull request
2 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds support for "commandline mode" to the command palette.
This allows the user to start typing a
wt.execommandline directly in the command palette, to run that commandline directly in the current window. This allows the user input something like> nt -p Ubuntu ; sp -p sshand open up a new tab and split it in the current window.References
wtaction from Add support for running awtcommandline in the curent window WITH A KEYBINDING #6537PR Checklist
Validation Steps Performed
Tested manually