Display meaningful errors when JSON types don't match #7241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For booleans, I opted to say
|
zadjii-msft
approved these changes
Aug 11, 2020
Comment on lines
+46
to
+52
| class TerminalApp::SettingsTypedDeserializationException final : public std::runtime_error | ||
| { | ||
| public: | ||
| SettingsTypedDeserializationException(const std::string_view description) : | ||
| runtime_error(description.data()) {} | ||
| }; | ||
|
|
There was a problem hiding this comment.
There's already TerminalWarnings.h - is that maybe a better place for this to be defined (I suppose this is a nit)
There was a problem hiding this comment.
Yeah... it is a better place but I was somewhat expecting that we would come plowing through here with a refactor eventually when we moved it to another dll
src/cascadia/TerminalApp/TerminalSettingsSerializationHelpers.h
Outdated
Show resolved
Hide resolved
zadjii-msft
added
Area-Settings
ghost
requested review from
miniksa,
carlos-zamora,
leonMSFT and
PankajBhojwani
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request completes (and somewhat rewrites) the JsonUtils error
handling arc. Deserialization errors, no longer represented by trees of
exceptions that must be rethrown and caught, are now transformed at
catch time into a message explaining what we expected and where we
expected it.
Instead of exception trees, a deserialization failure will result in a
single type of exception with the originating JSON object from which we
can determine the contents and location of the failure.
Because most of the error message actually comes from the JSON schema
or the actual supported types, and the other jsoncpp errors are not
localized I've made the decision to not localize these messages.