-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the "crossed-out" graphic rendition attribute #7143
Conversation
Note that I've marked this as closing #6205, although there is actually a second test case in that issue that isn't covered by this PR - using a combining long stroke Unicode character to achieve a strikethrough effect. That seems like it should be a completely separate issue, though, and wasn't something that the OP was particularly concerned about anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love me a good stackable PR that builds so cleanly on prior work. 😄
Thank you
Hello @DHowett! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 17 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
🎉 Handy links: |
This PR adds support for the ANSI crossed-out graphic rendition
attribute, which is enabled by the
SGR 9
escape sequence.originally added in Add support for passing through extended text attributes, like… #2917.
was added in Refactor grid line renderers with support for more line types #7107.
Since the majority of the code required for this attribute had already
been implemented, it was just a matter of activating the
GridLines::Strikethrough
style in theRenderer::s_GetGridlines
method when the
CrossedOut
attribute was set.VALIDATION
There were already some unit tests in place in
VtRendererTest
and theScreenBufferTests
, but I've also now extended the SGR tests inAdapterTest
to cover this attribute.I've manually confirmed the first test case from #6205 now works as
expected in both conhost and Terminal.
Closes #6205