Expose text selection through terminal WPF control API #7121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierdlg
changed the title
javierdlg
changed the title
|
@DHowett would it be possible to get a release for this PR? Doesn't need to go into the official feed, we just need a signed package that we can upload to our own feed and consume it in the VS side. |
ZoeyR
approved these changes
Jul 30, 2020
|
@javierdlg sure, what base version do you need this serviced to? |
DHowett
approved these changes
Jul 30, 2020
DHowett
changed the title
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Apologies, while this PR appears ready to be merged, it looks like |
DHowett
added
AutoMerge
ghost
merged commit
@DHowett microsoft.terminal.wpf.1.1.200720001-release1 is the latest official release, so that one works or any other more recent one. |
DHowett
pushed a commit
that referenced
this pull request
Jul 31, 2020
We've been trying to improve the copy/paste experience with the terminal in Visual Studio. Once of our problematic scenarios is when the terminal is connected to a remote environment and the user attempts to copy/paste. This gets forwarded to the remote shell that copy/paste into the remote clipboard instead of the local one. So we opted to add ctrl+shift+c/v to the terminal and need access to the selected text via the terminal control VALIDATION Tested with Visual Studio integrated terminal (cherry picked from commit f486a65)
DHowett
pushed a commit
that referenced
this pull request
Jul 31, 2020
We've been trying to improve the copy/paste experience with the terminal in Visual Studio. Once of our problematic scenarios is when the terminal is connected to a remote environment and the user attempts to copy/paste. This gets forwarded to the remote shell that copy/paste into the remote clipboard instead of the local one. So we opted to add ctrl+shift+c/v to the terminal and need access to the selected text via the terminal control VALIDATION Tested with Visual Studio integrated terminal (cherry picked from commit f486a65)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been trying to improve the copy/paste experience with the terminal
in Visual Studio. Once of our problematic scenarios is when the terminal
is connected to a remote environment and the user attempts to
copy/paste. This gets forwarded to the remote shell that copy/paste into
the remote clipboard instead of the local one.
So we opted to add ctrl+shift+c/v to the terminal and need access to the
selected text via the terminal control
VALIDATION
Tested with Visual Studio integrated terminal