Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed window title not updating with tab rename #7119

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Fixed window title not updating with tab rename #7119

merged 2 commits into from
Jul 30, 2020

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Jul 29, 2020 •
edited
Loading

Brief description of PR

The outer window title was not updating correctly with tab renames, this change fixes that

PR Checklist

  • Closes Window title is inconsistently updated with tab rename #6814
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

More detailed description

Previously, upon changing tabs we would send up the title of the focused control, this change makes it so we send up the title of the focused tab instead.

Validation steps

Cannot reproduce the bug after this change.

@ghost ghost added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Jul 29, 2020
@PankajBhojwani PankajBhojwani merged commit bf90869 into master Jul 30, 2020
@PankajBhojwani PankajBhojwani deleted the dev/pabhoj/window_title_consistency branch July 30, 2020 18:58
DHowett pushed a commit that referenced this pull request Jul 31, 2020
@PankajBhojwani @DHowett
Fixed window title not updating with tab rename (#7119)
6084670 
* Fixed window title not updating with tab rename

* pass the correct title to event handler instead

(cherry picked from commit bf90869)
@PankajBhojwani PankajBhojwani mentioned this pull request Aug 7, 2020
Closed
@ghost
Copy link

ghost commented Aug 13, 2020

🎉Windows Terminal Preview v1.2.2234.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Aug 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniksa miniksa miniksa approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Window title is inconsistently updated with tab rename
3 participants
@PankajBhojwani @carlos-zamora @miniksa