Add gutter to Command Palette to avoid overlapping with scrollbar #6965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
reviewed
Jul 17, 2020
DHowett
approved these changes
Jul 17, 2020
|
@msftbot merge this in 10 minutes |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
zadjii-msft
approved these changes
Jul 17, 2020
ghost
merged commit 
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command palette has some content that can overlap with its
scrollbar. This PR adds a 16px gutter for the scrollbar, as recommended
here.
Detailed Description of the Pull Request / Additional comments
You can repro the overlap in the default configuration by grabbing the
scrollbar with the mouse pointer. But there's an accessibility option
that makes this more obvious: Settings > Display > Automatically hide
scroll bars. With that option enabled, the text is always
overlapping.
The gutter does look slightly larger than it needs to be when the
scrollbar is thin or completely hidden. Dynamic reflow may help, but
unfortunately, I don't know enough XAML to wire that up. MUX has a
promising visual state named
ScrollBarsSeparatorExpanded, so thescientists suggest we could, while the designers are still pondering
whether we should.
Validation Steps Performed
Old appearance:
New appearance with fat scrollbars:
New appearance with thin scrollbars:
New appearance with no scrollbar:
