Add support for the "concealed" graphic rendition attribute #6907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and resetting the concealed attribute.
…ct on the color calculations.
ghost
added
Area-VT
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 15 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
DHowett
approved these changes
Jul 13, 2020
ghost
requested review from
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR adds support for the
SGR 8andSGR 28escape sequences,which enable and disable the concealed/invisible graphic rendition
attribute. When a character is output with this attribute set, it is
rendered with the same foreground and background colors, so the text is
essentially invisible.
PR Checklist
where discussion took place: Add support for the "concealed" graphic rendition attribute #6876
Detailed Description of the Pull Request / Additional comments
Most of the framework for this attribute was already implemented, so it
was just a matter of updating the
TextAttribute::CalculateRgbColorsmethod to make the foreground the same as the background when the
Invisible flag was set. Note that this has to happen after the
Reverse Video attribute is applied, so if you have white-on-black text
that is reversed and invisible, it should be all white, rather than all
black.
Validation Steps Performed
There were already existing SGR unit tests covering this attribute in
the
ScreenBufferTests, and theVtRendererTest. But I've added to theAdapterTestwhich verifies the SGR sequences for setting and resettingthe attribute, and I've extended the
TextAttributeTeststo verify thatthe color calculations return the correct values when the attribute is
set.
I've also manually confirmed that we now render the concealed text
values correctly in the ISO 6429 tests in Vttest. And I've manually
tested the output of concealed when combined with other attributes,
and made sure that we're matching the behaviour of most other terminals.