Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some logging regarding command palette usage #6821

Merged
1 commit merged into from
Jul 7, 2020
Merged

Add some logging regarding command palette usage #6821

1 commit merged into from
Jul 7, 2020

Conversation

zadjii-msft
Copy link
Member

Summary of the Pull Request

Pretty straightforward. Logs three scenarios:

  • The user opened the command palette (and which mode it was opened in)
  • The user ran a command from the palette
  • The user dismissed the palette without running an action.

We discussed this in team sync yesterday.

PR Checklist

  • I work here
  • [n/a] Requires documentation to be updated

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Gathering-Data We'd like to gather telemetry to influence our decision Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Jul 7, 2020
@DHowett DHowett added the Needs-Second It's a PR that needs another sign-off label Jul 7, 2020
@ghost ghost requested review from miniksa, carlos-zamora and leonMSFT July 7, 2020 20:54
carlos-zamora
carlos-zamora approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the extra abstraction too.

@DHowett
Copy link
Member

DHowett commented Jul 7, 2020

@msftbot merge this in 1 minute

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Jul 7, 2020
@ghost
Copy link

ghost commented Jul 7, 2020

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 07 Jul 2020 23:31:20 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 934ad98 into master Jul 7, 2020
@ghost ghost deleted the dev/migrie/f/research-cmdpal-usage branch July 7, 2020 23:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@DHowett DHowett DHowett approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Gathering-Data We'd like to gather telemetry to influence our decision Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zadjii-msft @DHowett @carlos-zamora