-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add actions missing in schema, descriptions for toggleRetroEffect
#6806
Conversation
* Add `commandPalette` et. al. to the schema * Add a description for the toggle retro effect command
…a command doesn't have keys bound
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value converter! I love it!
/cc @leonMSFT for some more xaml magic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Summary of the Pull Request
In the wake of #6635, a couple things got missed in merges:
toggleRetroEffect
didn't get into the schema, nor didrenameTab
orcommandPalette
.toggleRetroEffect
also didn't get a nameFurthermore, I thought it might be a good idea to start sticking
commands into
bindings
even withoutkeys
. So I tried doing that foropentabColorPicker
andtoggleRetroEffect
, and found immediately thatthe labels for the key chord still appear even when the text is empty.
So I added some XAML magic to hide those when the text is empty.
References
toggleRetroEffect
to schema #6762PR Checklist
toggleRetroEffect
to schema #6762Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Removed all my manual actions, ran the Terminal: