Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings to warn about large or multiline pastes #6631

Merged
13 commits merged into from
Jul 1, 2020
Merged

Add settings to warn about large or multiline pastes #6631

13 commits merged into from
Jul 1, 2020

Commits on Jun 22, 2020

  1. Add settings to warn when pasting text too large or with a new line c… 

    …haracter

Before sending calling the `HandleClipboardData` member function on
the `PasteFromClipboardEventArgs` object when we receive a request
from the `TermControl` to send it the clipboard's text content, we
now display a warning to let the user choose whether to continue or
not if the text is larger than 5 KiB or contains the _new line_
character, which can be a security issue if the user is pasting the
text in a shell.

These warnings can be disabled with the `largePasteWarning` and
`multiLinePasteWarning` global settings respectively.

I merged `TerminalPage::_PasteFromClipboardHandler` and
`TerminalPage::_PasteFromClipboardHandler` because I think that
the code is simpler this way.
    Greg Depoire--Ferrer committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    618a4c4 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. Fix formatting in Resources.resw

    Greg Depoire--Ferrer committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    0e515f5 View commit details
    Browse the repository at this point in the history

  2. Make dialog presentation waitable

    Greg Depoire--Ferrer committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    2c5e78c View commit details
    Browse the repository at this point in the history

  3. Use the IAsyncOperation returned by ShowDialog

    Greg Depoire--Ferrer committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    6385175 View commit details
    Browse the repository at this point in the history

  4. Use a weak reference to prevent circular dependency

    Greg Depoire--Ferrer committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    5d73dc7 View commit details
    Browse the repository at this point in the history

  5. Add 'IDialog' to spell checker's apis.txt

    Greg Depoire--Ferrer committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    6006394 View commit details
    Browse the repository at this point in the history

  6. Only resume_foreground if we actually need to display a warning dialog

    Greg Depoire--Ferrer committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    21eb079 View commit details
    Browse the repository at this point in the history

  7. Fix invalid name in FindName

    Greg Depoire--Ferrer committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    b8152fc View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Replace return by co_return to fix warning

    Greg Depoire--Ferrer committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    aaca27c View commit details
    Browse the repository at this point in the history

  2. Fix DialogPresenter comment

    Greg Depoire--Ferrer committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    0861584 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2020

  1. Change wording

    Greg Depoire--Ferrer committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    0f083cf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/microsoft/terminal into p… 

    …aste-warning
    Greg Depoire--Ferrer committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    33196af View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. Add missing close tag in Resources.resw

    Greg Depoire--Ferrer committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    b7dfde2 View commit details
    Browse the repository at this point in the history