Add copyFormatting keybinding arg and array support

[carlos-zamora]

Summary of the Pull Request

Adds array support for the existing copyFormatting global setting. This allows users to define which formats they would specifically like to be copied. A boolean value is still accepted and is translated to the following:

• false --> "none" or []
• true --> "all" or ["html", "rtf"]

This also adds copyFormatting as a keybinding arg for copy. As with the global setting, a boolean value and array value is accepted.

References

#5212 - Spec for formatted copying
#2690 - disable html copy

PR Checklist

• Closes Add setting to select which formats of copy to perform (text, rtf or html) #4191
• Closes copyFormatting Keybinding Arg for Copy #5262
• Tests added/passed
• Requires documentation to be updated

Detailed Description of the Pull Request / Additional comments

CopyFormat is a winrt enum where each accepted format is a flag. Currently accepted formats include html, and rtf. A boolean value is accepted and converted. true is a conjunction of all the formats. false only includes plain text.

For the global setting, null is not accepted. We already have a default value from before so no worries there.

For the keybinding arg, null (the default value) means that we just do what the global arg says to do. Overall, the copyFormatting keybinding arg is an override of the global setting when using that keybinding.

Validation Steps Performed

Validated behavior with every combination of values below:

• copyFormatting global: { true, false, [], ["html"] }
• copyFormatting copy arg: { null, true, false, [], [, "html"]}

[ghost]

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

[zadjii-msft]

shh bot, chill

[carlos-zamora]

Urgh. Thanks. I'll get to this one today.

[carlos-zamora]

@DHowett Latest commit tries to use the new Json Utils but I had some trouble. No longer builds. Could I get some help?

[DHowett]

only nits remaining are on the string formatting! well done

[carlos-zamora]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[carlos-zamora]

[ghost]

🎉Windows Terminal Preview v1.3.2382.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download