Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Windows Powershell default scheme to Campbell #5432

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

carlos-zamora
Copy link
Member

@carlos-zamora carlos-zamora commented Apr 20, 2020

Summary of the Pull Request

The "Campbell Powershell" color scheme does not have a high enough color contrast ratio. Campbell does, so we're changing it there.

PR Checklist

Validation Steps Performed

Updated Accessibility Insights results for updated color scheme

@carlos-zamora carlos-zamora added Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal. labels Apr 20, 2020
@DHowett-MSFT
Copy link
Contributor

image
This magic word will trigger a close.

@carlos-zamora
Copy link
Member Author

image
This magic word will trigger a close.

will close issue...

The key is to make it look similar, but confuse GitHub's bot haha

@DHowett-MSFT DHowett-MSFT merged commit 8a976c0 into master Apr 21, 2020
@DHowett-MSFT DHowett-MSFT deleted the dev/cazamor/a11y/color-scheme-contrast branch April 21, 2020 17:19
@ghost
Copy link

ghost commented Apr 22, 2020

🎉Windows Terminal Preview v0.11.1121.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Issues related to accessibility Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants