Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand env. vars in backgroundImage #3204

Merged
merged 12 commits into from
Nov 16, 2019
Merged

Expand env. vars in backgroundImage #3204

merged 12 commits into from
Nov 16, 2019

Commits on Oct 15, 2019

  1. Expands env-vars in background image paths 

    * Fixes #2922
* Adds HasBackgroundImage() and GetExpandedBackgroundImagePath() to
Profiles.cpp/h
* Fills Terminal Settings with expanded path, rather than path value
from profiles.json
* Adds simple regression tests to detect and fail if this fix is
circumvented in the future
    @bitcrazed
    bitcrazed committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    9677cd7 View commit details
    Browse the repository at this point in the history

  2. Added check for expansion in tests

    Rich Turner committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    daf6e3a View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. In-progress. Incomplete. Ignore

    @bitcrazed
    bitcrazed committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    c5df866 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. Merge branch 'master' into bitcrazed/Expand-Background-Image-Path

    Rich Turner committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    219d354 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into bitcrazed/Expand-Background-Image-Path

    Rich Turner committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    adbf678 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2019

  1. Fixed-up expanded icon path test

    Rich Turner committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    5085cc8 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2019

  1. Merge branch 'master' into bitcrazed/Expand-Background-Image-Path

    @bitcrazed
    bitcrazed committed Oct 19, 2019
    Configuration menu
    Copy the full SHA
    d82dd32 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2019

  1. Fixed unit test (layered JSON -> user settings)

    Rich Turner committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    31c611b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into bitcrazed/Expand-Background-Image-Path

    Rich Turner committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    6e6e8ec View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2019

  1. Corrected variable init 

    Co-Authored-By: Carlos Zamora <[email protected]>
    @carlos-zamora
    Rich Turner and carlos-zamora authored Oct 25, 2019
    Configuration menu
    Copy the full SHA
    873c90b View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. Merge branch 'master' into bitcrazed/Expand-Background-Image-Path

    Rich Turner committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    ff52fa5 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2019

  1. Moved win32_helpers.h include into LibararyIncludes.h

    Rich Turner committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    c0349e7 View commit details
    Browse the repository at this point in the history