AtlasEngine: Better builtin glyphs #18179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Area-Rendering
|
cc @grable0 (I apologize to "grable" without "0" for pinging them accidentally.)
(Ignore the different brightness in the middle. That's just a different theme.) |
|
200% scale
|
|
That looks real nice 😃 But i suspect a lot of the same people who complained about aliasing probably wont like this change.. |
DHowett
approved these changes
Nov 12, 2024
|
Hey @lhecker, how does it look at 100% scale using a UI like, say, Far Manager or MC? I am worried about the very thick lines, but maybe that is not a necessary concern... |
carlos-zamora
approved these changes
Nov 13, 2024
DHowett
pushed a commit
that referenced
this pull request
Nov 18, 2024
This slightly modifies the builtin glyph width and corner radius to more closely match Cascadia Mono. Previously, at low DPI (100% scale), the corner radius was barely noticeable which looked kind of bad. (cherry picked from commit a8e83c1) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgU6YuY Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slightly modifies the builtin glyph width and corner radius to
more closely match Cascadia Mono. Previously, at low DPI (100% scale),
the corner radius was barely noticeable which looked kind of bad.