Fix High Contrast mode in Settings UI #18130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
NOTE: the tab is fixed over in #18109 |
Robby8830
approved these changes
Oct 31, 2024
zadjii-msft
approved these changes
Oct 31, 2024
DHowett
approved these changes
Oct 31, 2024
DHowett
pushed a commit
that referenced
this pull request
Nov 15, 2024
"HighContrast" is not a possible requested theme. So `_UpdateBackgroundForMica()` would force the settings UI to be light or dark. To fix this, we just check if we're in high contrast mode and, if so, we don't bother setting the requested theme. (cherry picked from commit d04381e) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgUZ6MY Service-Version: 1.21
DHowett
pushed a commit
that referenced
this pull request
Nov 15, 2024
"HighContrast" is not a possible requested theme. So `_UpdateBackgroundForMica()` would force the settings UI to be light or dark. To fix this, we just check if we're in high contrast mode and, if so, we don't bother setting the requested theme. (cherry picked from commit d04381e) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgUZ6Mc Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"HighContrast" is not a possible requested theme. So
_UpdateBackgroundForMica()would force the settings UI to be light or dark. To fix this, we just check if we're in high contrast mode and, if so, we don't bother setting the requested theme.