-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape single quotes for WSL #18007
base: main
Are you sure you want to change the base?
Escape single quotes for WSL #18007
Conversation
@microsoft-github-policy-service agree |
Would it be simpler to paste with double quotes and handle escaping of significant characters like |
@lhecker I would prefer searching for just one character ( The inserting sequence |
Also, escaping just like Old: Additional references: |
This commit escapes single quotes (allowed in the Win32 subsystem) with `'\''` (finish quote, print a single quote then begin quote again), which is a valid escape in the context of the POSIX shell, when a file/ folder is dropped to a WSL tab.
bcf2c74
to
9eabd09
Compare
Hey, sorry about this - I didn't realize we had an open PR in this area when I changed how path translation works. You will probably have conflicts or outright failures once you merge |
Summary of the Pull Request
This commit escapes single quotes
'
(allowed in the Win32 subsystem) with'\''
(finish quote, print a single quote then begin quote again), which is a valid escape in the context of the POSIX shell, when a file/folder is dropped to a WSL tab.Note:
'"'"'
on the first submission of this PR.References and Relevant Issues
Detailed Description of the Pull Request / Additional comments
This is a follow-up of #16214 and fixes #18006.
Validation Steps Performed
PR Checklist