Check EnableHexNumpad before enabling it #17954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
DHowett
approved these changes
Sep 23, 2024
| nullptr, | ||
| &buffer[0], | ||
| &size); | ||
| return size == 4 && memcmp(&buffer[0], L"1", 4) == 0; |
There was a problem hiding this comment.
my gosh, it's actually a string? wild
There was a problem hiding this comment.
Should we use any of the wil registry helpers here? or is that just overhead.
things like wil::reg::try_get_value<string> and co
There was a problem hiding this comment.
I wouldn't. It's trivial code like this. I could replace the check with a wcsnlen though...
carlos-zamora
approved these changes
Sep 23, 2024
DHowett
pushed a commit
that referenced
this pull request
Sep 24, 2024
This just adds a quick registry check for `EnableHexNumpad`. Depends on #17774 Closes #17762 (again) ## Validation Steps Performed * Alt + NumpadAdd + 221E doesn't do anything ✅ * Set the `EnableHexNumpad` registry key * Restart * Alt + NumpadAdd + 221E inserts ∞ ✅ (cherry picked from commit b520da2) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgTQsd8 Service-Version: 1.21
DHowett
pushed a commit
that referenced
this pull request
Sep 24, 2024
This just adds a quick registry check for `EnableHexNumpad`. Depends on #17774 Closes #17762 (again) ## Validation Steps Performed * Alt + NumpadAdd + 221E doesn't do anything ✅ * Set the `EnableHexNumpad` registry key * Restart * Alt + NumpadAdd + 221E inserts ∞ ✅ (cherry picked from commit b520da2) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgTQseA Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds a quick registry check for
EnableHexNumpad.Depends on #17774
Closes #17762 (again)
Validation Steps Performed
EnableHexNumpadregistry key