Improve color contrast of reset button in SUI #17912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
This comment was marked as resolved.
This comment was marked as resolved.
DHowett
reviewed
Sep 16, 2024
| @@ -73,6 +76,9 @@ | |||
| ResourceKey="SystemColorWindowTextColorBrush" /> | |||
| <StaticResource x:Key="SettingContainerMessageForeground" | |||
| ResourceKey="SystemColorWindowTextColorBrush" /> | |||
|
|
|||
| <StaticResource x:Key="SettingContainerResetButtonIconForeground" | |||
| ResourceKey="SystemAccentColorLight1" /> | |||
There was a problem hiding this comment.
I do not know if this is correct in High Contrast - is there a more "contrasty" button content resource we should use?
There was a problem hiding this comment.
Looks like WinUI doesn't provide a recommendation here. But we got approval from the a11y folks: #17902 (comment)
I also like this value because it keeps the accent color in use, so the app still looks and feels personalized to the user.
DHowett
approved these changes
Sep 24, 2024
lhecker
approved these changes
Sep 25, 2024
DHowett
pushed a commit
that referenced
this pull request
Sep 26, 2024
DHowett
pushed a commit
that referenced
this pull request
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a theme resource for the color of the reset button in the settings UI.
Closes #17902