Fix text scaling issues in settings UI #17910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
lhecker
reviewed
Sep 12, 2024
DHowett
approved these changes
Sep 16, 2024
lhecker
approved these changes
Sep 17, 2024
DHowett
pushed a commit
that referenced
this pull request
Sep 17, 2024
## Summary of the Pull Request Fixes some issues with truncated text in the settings UI when 200% text scaling is applied. For #17897, a minimum height was applied instead of a plain "height". This ensures that the desired height is applied in general, but under 200% text scaling, we are allowed to grow past that, thus preventing the truncation of the text. For #17898, flyouts have a scroll viewer inside them by default. We actually don't want the scroll viewer because that means the text will appear "truncated" when in reality, the user is expected to notice the small scrollbar and scroll horizontally (why that's the default, I will never know). This PR introduces a new style that can be applied to these flyouts to cause text wrapping instead of horizontal scrolling. Looked through the app for any instances where this happens. For #12006, simply changing the column width from a static value to "auto" fixes the issue. Frankly, we care more about the text appearing as a whole (and as whole words). The name of the actions wrap properly anyways. Closes #17897 Closes #17898 Closes #12006 (cherry picked from commit a7e47b7) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgTEfj0 Service-Version: 1.21
DHowett
pushed a commit
that referenced
this pull request
Sep 17, 2024
## Summary of the Pull Request Fixes some issues with truncated text in the settings UI when 200% text scaling is applied. For #17897, a minimum height was applied instead of a plain "height". This ensures that the desired height is applied in general, but under 200% text scaling, we are allowed to grow past that, thus preventing the truncation of the text. For #17898, flyouts have a scroll viewer inside them by default. We actually don't want the scroll viewer because that means the text will appear "truncated" when in reality, the user is expected to notice the small scrollbar and scroll horizontally (why that's the default, I will never know). This PR introduces a new style that can be applied to these flyouts to cause text wrapping instead of horizontal scrolling. Looked through the app for any instances where this happens. For #12006, simply changing the column width from a static value to "auto" fixes the issue. Frankly, we care more about the text appearing as a whole (and as whole words). The name of the actions wrap properly anyways. Closes #17897 Closes #17898 Closes #12006 (cherry picked from commit a7e47b7) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgTEfj8 Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixes some issues with truncated text in the settings UI when 200% text scaling is applied.
For #17897, a minimum height was applied instead of a plain "height". This ensures that the desired height is applied in general, but under 200% text scaling, we are allowed to grow past that, thus preventing the truncation of the text.
For #17898, flyouts have a scroll viewer inside them by default. We actually don't want the scroll viewer because that means the text will appear "truncated" when in reality, the user is expected to notice the small scrollbar and scroll horizontally (why that's the default, I will never know). This PR introduces a new style that can be applied to these flyouts to cause text wrapping instead of horizontal scrolling. Looked through the app for any instances where this happens.
For #12006, simply changing the column width from a static value to "auto" fixes the issue. Frankly, we care more about the text appearing as a whole (and as whole words). The name of the actions wrap properly anyways.
Closes #17897
Closes #17898
Closes #12006