Dedup command history by default #17852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
carlos-zamora
approved these changes
Sep 3, 2024
DHowett
pushed a commit
that referenced
this pull request
Sep 4, 2024
Under ConPTY we don't load any user settings. `SetUpConsole` notes: > If we are [ConPTY], we don't want to load any user settings, > because that could result in some strange rendering results [...] This enables deduplication by default, which I figured wouldn't cause any regressions since it's a user-controllable setting anyway, while it's clearly something the average user wants enabled, for the same reason that PSReadLine has HistoryNoDuplicates enabled by default. Closes #17797 ## Validation Steps Performed * Launch conhost, enter 2 commands, press F7, select the older one, press Enter, press F7. 2 entries ✅ * Launch WT, enter 2 commands, press F7, select the older one, press Enter, press F7. 2 entries ✅ (cherry picked from commit 5fdfd51) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgSN1FM Service-Version: 1.21
DHowett
pushed a commit
that referenced
this pull request
Sep 4, 2024
Under ConPTY we don't load any user settings. `SetUpConsole` notes: > If we are [ConPTY], we don't want to load any user settings, > because that could result in some strange rendering results [...] This enables deduplication by default, which I figured wouldn't cause any regressions since it's a user-controllable setting anyway, while it's clearly something the average user wants enabled, for the same reason that PSReadLine has HistoryNoDuplicates enabled by default. Closes #17797 ## Validation Steps Performed * Launch conhost, enter 2 commands, press F7, select the older one, press Enter, press F7. 2 entries ✅ * Launch WT, enter 2 commands, press F7, select the older one, press Enter, press F7. 2 entries ✅ (cherry picked from commit 5fdfd51) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgSN1FQ Service-Version: 1.22
|
Hi, sorry if this is the wrong place to ask but, uh, how do you disable this change? I have HistoryNoDup set in the registry and CMD.exe respects it but windows terminal doesn't seem to. I hadn't noticed before this change was made, but now it means my history isn't working properly lol. (Deduping the history makes it a lot less useful for me, as you can't go back to a previous command and press down+enter repeatedly to replay the history sequence, which is very useful in applications that use the default console line input). |
lhecker
added
the
Needs-Discussion
lhecker
removed
the
Needs-Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under ConPTY we don't load any user settings.
SetUpConsolenotes:This enables deduplication by default, which I figured wouldn't cause
any regressions since it's a user-controllable setting anyway, while
it's clearly something the average user wants enabled, for the same
reason that PSReadLine has HistoryNoDuplicates enabled by default.
Closes #17797
Validation Steps Performed
press Enter, press F7. 2 entries ✅
press Enter, press F7. 2 entries ✅