Fix ScrollRect to DECCRA translation #17849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
lhecker
force-pushed
the
dev/lhecker/17801-scroll-rect-fixup
branch
from
76d8507
to
90846ce
Compare
carlos-zamora
approved these changes
Sep 3, 2024
DHowett
approved these changes
Sep 4, 2024
DHowett
pushed a commit
that referenced
this pull request
Sep 6, 2024
By translating the clip rectangle into a source-relative coordinate space we can calculate the intersection that must be copied much much more easily. I should've done that from the start. Closes #17801 ## Validation Steps Performed * Test code provided in #17801 (cherry picked from commit d2c3cfd) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgSa7nQ Service-Version: 1.22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By translating the clip rectangle into a source-relative coordinate
space we can calculate the intersection that must be copied
much much more easily. I should've done that from the start.
Closes #17801
Validation Steps Performed