Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A trio of snippets pane fixes #17794

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Conversation

zadjii-msft
Copy link
Member

  1. Don't crash on a cmdpal "duplicate pane" of a snippets pane
    • Found while trying to solve bug the third.
    • "Duplicate pane" with a snippets pane would crash. This was due to us attempting to PreviewText when there was no buffer yet. (_activeBuffer() strikes again)
  2. dismiss the preview from cmdpal correctly too
    • Again while looking for part the third, I hit this
    • I have a sendInput(input: "a") command. This is the first command in the palette. And opening a new pane would... preview that command in the new pane? weird. Moving the line in CommandPalette::_close fixes this
  3. Don't crash when we're restoring a snippets pane and there's a bunch of windows
    • This was the real bug I was trying to fix
    • Looks like if you have enough panes & windows, there's enough of a delay between ctoring a snippets pane and actually calling _UpdateSettings on it, that the XAML loads and tries to bind to _allTasks, which hadn't been constructed yet
    • closes Crash on launch with a snippets pane, and multiple windows(?) #17793

@DHowett DHowett merged commit ef96055 into main Aug 23, 2024
20 checks passed
@DHowett DHowett deleted the dev/migrie/b/dont-crash-restore-snippets branch August 23, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on launch with a snippets pane, and multiple windows(?)
3 participants