Guard Control UpdateAppearance/Settings against UAF #17770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
DHowett
commented
Aug 22, 2024
| @@ -717,11 +717,14 @@ namespace winrt::Microsoft::Terminal::Control::implementation | |||
| // terminal. | |||
| co_await wil::resume_foreground(Dispatcher()); | |||
|
|
|||
| _core.UpdateSettings(settings, unfocusedAppearance); | |||
There was a problem hiding this comment.
yeah this function had a weakThis and then just, like, gave up on it.
carlos-zamora
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you close a window, it naturally loses focus.
We were trying to use members of the control to update its appearance on focus loss after it got torn down.
Closes #17520