x-save the commandline in the current window
#17758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By manually setting the `_windowTarget` to `0`, we can make sure to toss `x-save` commandlines at the current terminal window (so long as there is one). Edge cases: * You passed other subcommands with `x-save`: Well, we'll do whatever we would have normally done for multiple subcommands. We won't `x-save` in the current window, we'll obey your settings. That seems to make sense * You ran `wt x-save` without an open Terminal window: We'll open a terminal window during the process of handling it. That seems sensible. Closes #17366
microsoft-github-policy-service
bot
added
Issue-Bug
DHowett
approved these changes
Aug 21, 2024
| // Validate the args now. This will make sure that in the case of a | ||
| // single x-save command, we toss that commandline to the current | ||
| // terminal window | ||
| appArgs.ValidateStartupCommands(); |
There was a problem hiding this comment.
yikes that validate means "change"
There was a problem hiding this comment.
and apparently "partially parse"! AppCommandlineArgs.cpp R1044
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By manually setting the
_windowTargetto0, we can make sure to tossx-savecommandlines at the current terminal window (so long as there is one).Edge cases:
x-save: Well, we'll do whatever we would have normally done for multiple subcommands. We won'tx-savein the current window, we'll obey your settings. That seems to make sensewt x-savewithout an open Terminal window: We'll open a terminal window during the process of handling it. That seems sensible.Closes #17366