Fix a crash when disabling the ASB #17748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
carlos-zamora
approved these changes
Aug 20, 2024
DHowett
reviewed
Aug 20, 2024
| @@ -336,6 +336,9 @@ void WriteCharsVT(SCREEN_INFORMATION& screenInfo, const std::wstring_view& str) | |||
| { | |||
| auto& gci = ServiceLocator::LocateGlobals().getConsoleInformation(); | |||
| auto& stateMachine = screenInfo.GetStateMachine(); | |||
| // If the given screenInfo is the alternate screen buffer, disabling the alternate screen buffer in this | |||
| // VT payload will cause the pointer to be invalidated. We thus need to get all the information we need now. | |||
| const auto disableNewlineTranslation = WI_IsFlagSet(screenInfo.OutputMode, DISABLE_NEWLINE_AUTO_RETURN); | |||
There was a problem hiding this comment.
Suggested change
| const auto disableNewlineTranslation = WI_IsFlagSet(screenInfo.OutputMode, DISABLE_NEWLINE_AUTO_RETURN); | |
| const auto disableNewlineTranslation = WI_IsFlagSet(screenInfo.OutputMode, DISABLE_NEWLINE_AUTO_RETURN); | |
| wil::hide_name screenInfo; |
May be worth considering? If it will compile.
I mean, but you'd need to do it below 344.
DHowett
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProcessStringmay delete the ASB and cause a dangling screen infopointer. As such, we must avoid using the pointer after the call.
Closes #17709
Validation Steps Performed
I couldn't repro the issue.