Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add elipses back in to some command names #17715

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Add elipses back in to some command names #17715

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
65bc773
Add elipses back in to some command names
carlos-zamora Aug 14, 2024
7b430fd
update strings according to comment
carlos-zamora Aug 14, 2024
a3be3b5
apply feedback
carlos-zamora Aug 20, 2024
633328a
oops, forgot one
carlos-zamora Aug 20, 2024
4e6a2ec
let's try that again
carlos-zamora Aug 20, 2024
771ddcc
bring back the ... (at least for the nested ones)
carlos-zamora Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,13 @@
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<data name="SetColorSchemeParentCommandName" xml:space="preserve">
<value>Select color scheme</value>
<value>Select color scheme...</value>
</data>
<data name="NewTabParentCommandName" xml:space="preserve">
<value>New tab</value>
<value>New tab...</value>
</data>
<data name="SplitPaneParentCommandName" xml:space="preserve">
<value>Split pane</value>
<value>Split pane...</value>
</data>
<data name="SnippetsPaneCommandName" xml:space="preserve">
<value>Open snippets pane</value>
Expand Down Expand Up @@ -329,7 +329,7 @@
<comment>{Locked="JSON"}. "JSON" is the extension of the file that will be opened.</comment>
</data>
<data name="OpenTabColorPickerCommandKey" xml:space="preserve">
<value>Set the tab color</value>
<value>Set tab color...</value>
</data>
<data name="PasteTextCommandKey" xml:space="preserve">
<value>Paste</value>
Expand All @@ -351,7 +351,7 @@
<value>Reset tab title</value>
</data>
<data name="OpenTabRenamerCommandKey" xml:space="preserve">
<value>Rename tab title</value>
<value>Rename tab</value>
</data>
<data name="ResizePaneCommandKey" xml:space="preserve">
<value>Resize pane</value>
Expand Down Expand Up @@ -445,17 +445,14 @@
<value>Switch to the last tab</value>
</data>
<data name="TabSearchCommandKey" xml:space="preserve">
<value>Search for tab</value>
<value>Search for tab...</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this (these?) use … instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My vote is that Search for tab... should have the ... because the action is requesting more information before it's completed. Invoking the action doesn't search; it opens a new control that then requests for more information (via textbox) to then search for the tab.

Based this decision on generalizing this, but open to discuss and change 😊.

Copy link
Member

@lhecker lhecker Aug 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant whether we should use the dedicated ellipsis Unicode character for this: https://www.compart.com/en/unicode/U+2026

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! My stance is "eh". Is there a value to switching over to the unicode character? Screen readers seem to handle it no differently.

</data>
<data name="ToggleAlwaysOnTopCommandKey" xml:space="preserve">
<value>Toggle always on top mode</value>
</data>
<data name="ToggleCommandPaletteCommandKey" xml:space="preserve">
<value>Toggle command palette</value>
</data>
<data name="SuggestionsCommandHistoryCommandKey" xml:space="preserve">
<value>Recent commands</value>
</data>
<data name="SuggestionsCommandKey" xml:space="preserve">
<value>Open suggestions</value>
</data>
Expand Down Expand Up @@ -519,7 +516,7 @@
<value>Reset window name</value>
</data>
<data name="OpenWindowRenamerCommandKey" xml:space="preserve">
<value>Rename window</value>
<value>Rename window...</value>
</data>
<data name="DisplayWorkingDirectoryCommandKey" xml:space="preserve">
<value>Display Terminal's current working directory</value>
Expand Down Expand Up @@ -570,7 +567,7 @@
<value>Quit the Terminal</value>
</data>
<data name="SetOpacityParentCommandName" xml:space="preserve">
<value>Set background opacity</value>
<value>Set background opacity...</value>
</data>
<data name="IncreaseOpacityCommandKey" xml:space="preserve">
<value>Increase background opacity by {0}%</value>
Expand Down
Loading