Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AtlasEngine: Fix curly line rendering on rows with line renditions #17679

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Aug 7, 2024

This fixes several scaling issues with double width/height rows.

Validation Steps Performed

  • Run RenderTests

@lhecker lhecker added Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Area-AtlasEngine labels Aug 7, 2024
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This results in the same rendering for normal rendition, right?

D2D looks way better, so I suspect this makes D3D look like that

@lhecker
Copy link
Member Author

lhecker commented Aug 7, 2024

This results in the same rendering for normal rendition, right?

Yeah exactly, because the renditionScale will be 1.

@lhecker lhecker merged commit d4c1dad into main Aug 7, 2024
20 checks passed
@lhecker lhecker deleted the dev/lhecker/atlas-curly-fixup branch August 7, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-AtlasEngine Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants