Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cooked read reflow under ConPTY #17668

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Aug 5, 2024

This delays the CSI J until we know the new origin of the prompt.
That way it's at the right (reflowed) position.

Validation Steps Performed

  • conhost
    • Print a ton of text
    • Write a prompt of a hundred chars
    • Resize the window very narrow / wide
    • Works ✅
  • Windows Terminal
    • Write a prompt of a hundred chars
    • Resize the window very narrow / wide
    • Works ✅

@lhecker lhecker added Product-Conpty For console issues specifically related to conpty Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Priority-2 A description (P2) labels Aug 5, 2024
@DHowett DHowett merged commit 9d0180a into main Aug 7, 2024
20 checks passed
@DHowett DHowett deleted the dev/lhecker/fix-cooked-reflow branch August 7, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Conpty For console issues specifically related to conpty Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Known unresolved issues after removing VtEngine / adding VT passthrough
3 participants