Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the VT answerback capability #17660

Merged
merged 6 commits into from
Aug 7, 2024

Conversation

j4james
Copy link
Collaborator

@j4james j4james commented Aug 3, 2024

The answerback feature allows for the user to define a message that the
terminal will transmit to the host whenever an ENQ (enquiry) control
character is received.

Detailed Description of the Pull Request / Additional comments

In Windows Terminal, the message can be configured at the profile level
of the settings file, as a string property named AnswerbackMessage.

In ConHost, the message can be configured in the registry, again as a
string value with the name AnswerbackMessage.

Validation Steps Performed

I've confirmed that the control is working as intended in both Windows
Terminal and ConHost using Vttest.

Closes #11946

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Task It's a feature request, but it doesn't really need a major design. Area-VT Virtual Terminal sequence support Product-Conhost For issues in the Console codebase labels Aug 3, 2024
@j4james j4james marked this pull request as ready for review August 3, 2024 17:50
Copy link
Member

@lhecker lhecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 bug, otherwise lgtm.

src/host/settings.hpp Outdated Show resolved Hide resolved
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently I reviewed all 24 files and completely forgot. Thanks for doing this!

@DHowett DHowett merged commit 746cf1f into microsoft:main Aug 7, 2024
15 checks passed
@j4james j4james deleted the feature-answerback branch August 8, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-VT Virtual Terminal sequence support Issue-Task It's a feature request, but it doesn't really need a major design. Product-Conhost For issues in the Console codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for VT100 Answerback Feature
3 participants