Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sixels in BackendD2D #17636

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix sixels in BackendD2D #17636

merged 1 commit into from
Jul 31, 2024

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Jul 31, 2024

Whoops.

@lhecker lhecker added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-AtlasEngine labels Jul 31, 2024
DHowett
DHowett reviewed Jul 31, 2024
View reviewed changes
src/renderer/atlas/BackendD2D.cpp
@@ -772,7 +772,7 @@ void BackendD2D::_drawBitmap(const RenderingPayload& p, const ShapedRow* row, u1
const auto left = (b.targetOffset - p.scrollOffsetX) * cellWidth;
const auto right = left + b.targetWidth * cellWidth;
const auto top = y * cellHeight;
const auto bottom = left + cellHeight;
const auto bottom = top + cellHeight;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HA

zadjii-msft
zadjii-msft approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops

@lhecker lhecker merged commit 50fe0f8 into main Jul 31, 2024
20 checks passed
@lhecker lhecker deleted the dev/lhecker/d2d-sixels branch July 31, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-AtlasEngine Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lhecker @DHowett @zadjii-msft