Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alt-numpad events #17635

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Fix alt-numpad events #17635

merged 1 commit into from
Jul 31, 2024

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Jul 30, 2024 •
edited
Loading

This fixes a regression caused by 5b44476 which accidentally moved
the two pushes into the if condition.

Closes MSFT:52463679

Validation Steps Performed

  • Enable Feature_UseNumpadEventsForClipboardInput
  • cmd
  • chcp 54936
  • Paste narrow Unicode characters like ①
  • It works ✅

@lhecker lhecker added Product-Conhost For issues in the Console codebase Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) labels Jul 30, 2024
@lhecker lhecker merged commit 9bafa52 into main Jul 31, 2024
20 checks passed
@lhecker lhecker deleted the dev/lhecker/52463679-alt-numpad-events branch July 31, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Conhost For issues in the Console codebase
Projects
Inbox Servicing Pipeline
Status: To Cherry Pick
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lhecker @DHowett @zadjii-msft