Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unused TextBuffer methods #17443

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Jun 19, 2024

This is simply some unused code from the days before the big
text buffer rewrite in #13626.

@lhecker lhecker added the Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. label Jun 19, 2024
TextAttribute attr{ 0x7f };
auto _buffer = std::make_unique<TextBuffer>(bufferSize, attr, cursorSize, false, _renderer);

// This is the burrito emoji: 🌯
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goodbye sweet burrito test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have more complex tests in its place now (just below this one IIRC). 😌

@lhecker lhecker added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit e0686fa Jun 20, 2024
28 of 29 checks passed
@lhecker lhecker deleted the dev/lhecker/textbuffer-cleanup branch June 20, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants