Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the renderer optional #17442

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Make the renderer optional #17442

merged 5 commits into from
Jun 20, 2024

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Jun 19, 2024

If VtEngine gets removed from conhost, we need to be able to run
without any renderer present whatsoever. To make this possible,
I've turned all Renderer& into Renderer*.

Part of #14000

@lhecker lhecker added Product-Conhost For issues in the Console codebase Area-VT Virtual Terminal sequence support labels Jun 19, 2024
@DHowett DHowett enabled auto-merge June 20, 2024 17:21
@DHowett DHowett added this pull request to the merge queue Jun 20, 2024
Merged via the queue into main with commit bd116e3 Jun 20, 2024
28 checks passed
@DHowett DHowett deleted the dev/lhecker/14000-optional-renderer branch June 20, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-VT Virtual Terminal sequence support Product-Conhost For issues in the Console codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lhecker @DHowett @zadjii-msft